Re: Zekr 0.6.0 final is ready

[Mohammad Derakhshani <derakhshani at gmail dot com>]

Salaam,

Thank you, Mohammed Adnène Trojette and Mohammed Sameer, for reviewing
Zekr.

I have applied most of your comments and uploaded zekr again.
For the time being I put ttf-sil-scheharzade in Recommends
So, zekr runtime-dependencies can be satisfied.
please if you have any more comments let me know.

I answered the comments bellow.
Mohsen 2 of the following comments needs your attention.

Mohammed Adnène Trojette:
 - debian/control
   --------------

1/ Please fix the Maintainer: field, as we are going to do it the
Debian way ;-)
*fixed*
2/ "B-D: dpatch" --> I really suggest you use quilt.
*I am not familiar with quilt. maybe for next updates :)*
3/ Depends: on ${misc:Depends} and ${shlibs:Depends}
*done*
4/ Do you really need dependency relationships with all the fonts
packages?

 | Depends: ttf-kacst, ttf-scheherazade, ttf-farsiweb, ttf-freefont
 | Recommends: ttf-nafees, ttf-freefarsi, msttcorefonts
*a few unnecessary fonts were removed*
*for the time being, ttf-sil-scheharzade is moved to Recommends, and
ttf-nafees is removed*
5/ I am not sure you need to Suggest all the l10n packages
6/ Description: don't start it with a "A"
(see
 |
http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-bpp-desc-basics
 | 6.2.1 and 6.2.2)
*done*


 - debian/copyright
   ----------------

1/ Update the year in the Copyrights
*done*
2/ s/domian/domain/
*done*
3/ I don't know the status of the Eclipse license wrt the DFSG
4/ The copyright file is really well written :)
*thank you :)*


 - debian/rules
   ------------

1/ You don't need to call dh_install
*removed*
2/ Make use of DEB_VERSION instead of computing it
*done*
3/ No need for DEB_FINALDIR
*Why?*
4/ Use debian/dirs to create /usr/bin
*done*
5/ No need for dh_installchangelogs doc/changes.txt nor dh_installdocs
debian/README.source if you list these files in debian/docs
*done*
6/ No need for a clean:: target (it is implicit)
*removed*
7/ For the get-orig-source:: target, don't you prefer running uscan
along with a debian/watch file?

*In new releases of Zekr new features and libraries are added, 
So Zekr needs manual packaging. I do not think using debian/watch, for
automatic updating, is a proper way of packaging zekr*
*Also, I am not familiar enough with uscan and watch file*
8/ Please try to get upstream (you? :) remove all the useless files
(*.zip, *.jar, ...) and provide them apart on his website. That's the
best way to get zekr distribution-friendly (for Debian, Mandriva, and
others)
*needs mohsen's attention. Personally I do not like this idea.*
9/ Why is the package repackaged and called .dfsg? Are there non-free
files in the upstream tarball?
*yes there were: translations and jar libs. I removed them all.*


- debian/README.Debian
   --------------------


Please reword it including README.source and making it distribution
neutral (that's to say transparent to Debian/Ubuntu).

For instance:

>>>
Zekr comes with translations in French, Spanish, Foo, Bar packaged as
zekr-quran-translations-XY where XY is the ISO code of the
language. Run
  $ apt-cache search zekr-quran-translations
in a shell to list them all.
<<<
*done*
Or put that in a README and install it using debian/docs.



README.Debian is for Debian-specific informations.

 - debian/zekr.1
   -------------

Please clean it from all the comments.
*done*

 - debian/changelog
   ----------------

1/ Please use a Debian version number and a Debian distribution target
*done*
2/ Only mention "Initial release. (Closes: #nnnnnn)" where #nnnnnn is
your ITP bug number
*done*
3/ Update the date (hint: use dch from the devscripts package to edit
the changelog file)
*done*


 - debian/zekr.sh
   --------------

Please check if this is the proper way to make use of Mozilla's
browsers
(see other packages that do that or tell me and I'll ask the
maintainer
what the proper way is).

*that's the right way to set MOZILLA_FIVE_HOME.
/usr/bin/eclipse from eclipse package sets MOZILLA_FIVE_HOME in the
same way*


That's all for the first glance. Good work already. Please keep it up
and make the according changes so that we can send this to NEW ;-)


 - debian/watch
------------
*each time new features and libraries are added to zekr, which need
manual packaging. I do not think using debian/watch for automatic
updating is a proper way of packaging zekr. Also I am not very familiar
with uscan and watch file.*


Please add such a file (see uscan(1)) for more information.

Next steps:
 - build-time checks
 - lintian and linda checks
 - piuparts checks
 - runtime checks



Mohammed Sameer:

debian/control: drop Zekr from the short description.
*done*

The instructions in README.Debian don't apply to debian. Debian has
no universe/multiverse. Probably you are also assuming gnome which
isn't correct as debian ships a lot of DEs.
*README.Debian & README.source were fixed."

debian/changelog: I'm not sure if listing what was patched there is
a good idea or not.
*removed*

debian/copyright: Missing the email for upstream.
*done*

what's res/./bookmark/.DONOTDELETE ?
*That was in the zekr upstream tar.gz. I do not know*
*it needs Mohsen's attention*


guess you need iceweasel instead of firefox in the Depends line.
*zekr does not work with iceweasel (It was tested before)*

zekr is un-installable (depends on ttf-scheherazade but ttf-scheherazade
is not in the archive ?)
*for now I put this font in recommends. Another person is working on
ttf-sil-scheherazade*


/usr/bin/zekr: line 23: --warning: command not found
*if all the dependencies are satisfied you do not get such error.
How did you get this error?
anyway I fixed this bug by changing $zenity in line 23 to zenity*

Why is the license in /usr/bin/zekr the GPL ?
I thought it's under an apache license ?
*changed to apache 2.0* 

Mohammed Adnène Trojette:
does it depend on any browser or on firefox precisely?
If it depends on any browser, please prefer depending on www-browser.
*Zekr uses SWT and so it should depend on firefox | iceape | xulrunner
that similar to eclipse pacakge. please see /usr/bin/eclipse*

Best,
Mohammad Derakhshani