Re: RFS: acon & thwab-lib

[Ahmed El-Mahmoudy <aelmahmoudy at users dot sourceforge dot net>]

On Mon, Sep 24, 2007 at 03:49:46PM +0200, Mohammed Sameer wrote:
> > On Thu, Sep 13, 2007 at 02:14:16PM +0200, Mohammed Sameer wrote:
> > > On Thu, Sep 13, 2007 at 01:57:25PM +0200, Mohammed Adnène Trojette wrote:
> > > > On Wed, Sep 12, 2007, Mohammed Sameer wrote:
> > > > > * Binary files (should not be there):
> > > > >    bin/itar
> > > > >    bin/thwab-lib
> > > > 
> > > > There is only the empty bin/ directory.
> > > 
> > > the clean target will clean it:
> > > rm -rf thwab-lib-1.1.2/ && dpkg-source -x thwab-lib_1.1.2-1.dsc  && ls thwab-lib-1.1.2/bin/
> > > dpkg-source: warning: extracting unsigned source package (./thwab-lib_1.1.2-1.dsc)
> > > dpkg-source: extracting thwab-lib in thwab-lib-1.1.2
> > > dpkg-source: unpacking thwab-lib_1.1.2.orig.tar.gz
> > > dpkg-source: applying ./thwab-lib_1.1.2-1.diff.gz
> > > itar  thwab-lib
> > 
> > So is that acceptable or not ? Shall I make the clean target also 
> > remove:
> > share/locale/ar/LC_MESSAGES/thwab.mo
> > Python/iTar.pyc
> 
> No it's not. You will have to make sure they are being deleted in the 
> debian/rules clean target.

I don't understand. Doesn't the debian/rules clean target call the 
upstream's Makefile clean target, hence the binary files are removed. So 
why it is not accepted ?

> Python/iTar.pyc is not really needed I guess. We will have to take care of the python
> modules later but I'm still reading about that.
> I need to go through the python policy.

Do you mean, it is not really needed to be removed from source package ?

> Please patch Makefile to build share/locale/ar/LC_MESSAGES/thwab.mo if needed.

I don't knmow how to build share/locale/ar/LC_MESSAGES/thwab.mo. If you 
know how please tell me ?

> Then please put a small howto in README.Debian
> Just to make the lives of our users easier ;-)

Ok & thanks a lot for the help.