On Mon, Sep 24, 2007 at 08:42:37AM +0200, Ahmed El-Mahmoudy wrote: > On Wed, Sep 12, 2007 at 08:48:37PM +0200, Mohammed Sameer wrote: > > * P.S. gcc -O6 ? > > What about it ? I thought nothing is after -O3 ? No harm anyway. > On Thu, Sep 13, 2007 at 02:14:16PM +0200, Mohammed Sameer wrote: > > On Thu, Sep 13, 2007 at 01:57:25PM +0200, Mohammed Adnène Trojette wrote: > > > On Wed, Sep 12, 2007, Mohammed Sameer wrote: > > > > * Binary files (should not be there): > > > > bin/itar > > > > bin/thwab-lib > > > > > > There is only the empty bin/ directory. > > > > the clean target will clean it: > > rm -rf thwab-lib-1.1.2/ && dpkg-source -x thwab-lib_1.1.2-1.dsc && ls thwab-lib-1.1.2/bin/ > > dpkg-source: warning: extracting unsigned source package (./thwab-lib_1.1.2-1.dsc) > > dpkg-source: extracting thwab-lib in thwab-lib-1.1.2 > > dpkg-source: unpacking thwab-lib_1.1.2.orig.tar.gz > > dpkg-source: applying ./thwab-lib_1.1.2-1.diff.gz > > itar thwab-lib > > So is that acceptable or not ? Shall I make the clean target also > remove: > share/locale/ar/LC_MESSAGES/thwab.mo > Python/iTar.pyc No it's not. You will have to make sure they are being deleted in the debian/rules clean target. > Btw, I looked at the Makefile, it seems that those 2 files aren't built > during make process ! Python/iTar.pyc is not really needed I guess. We will have to take care of the python modules later but I'm still reading about that. I need to go through the python policy. Please patch Makefile to build share/locale/ar/LC_MESSAGES/thwab.mo if needed. > > On Thu, Sep 13, 2007 at 01:57:25PM +0200, Mohammed Adnène Trojette wrote: > > On Wed, Sep 12, 2007, Mohammed Sameer wrote: > > > * Please document how to enable some users to download data files in README.Debian > > > > Or even provide a script or a link. > > What if the information is already available from upstream in > /usr/share/doc/thwab-lib/en/files/02_01_05.html ? Then please put a small howto in README.Debian Just to make the lives of our users easier ;-) -- GPG-Key: 0xA3FD0DF7 - 9F73 032E EAC9 F7AD 951F 280E CB66 8E29 A3FD 0DF7 Debian User and Developer. Homepage: www.foolab.org
Attachment:
signature.asc
Description: Digital signature