On Wed, Sep 12, 2007 at 02:53:29PM +0200, Ahmed El-Mahmoudy wrote: > as-salamu alaykom, > > On Wed, Sep 12, 2007 at 02:11:52PM +0200, Mohammed Sameer wrote: > > in the copyright file you have: > > Upstream Author: Ahmed Abdel-Hamid Mohamed <ahmedam at mail dot usa dot com> > > License: > > Copyright (C) 1999-2000 Kristian Gunstone <kristian dot gunstone at pean dot org> > > > > it doesn't state that the work is copyrighted Ahmed Abdel-Hamid Mohamed ? > > Who is Kristian Gunstone ? Why is he mentioned ? > Oh, that was a typo ! I fixed it. Can you please add that to the changelog ? > > Why are you Using install -m 4755 instead of dpkg-override to set setuid for acon. ? > The previous sponsor wanted it that way I think. Also the original > Makefile had it this way: install -m 4711 > I just patched it to be 4755. He didn't say why ? Weird. > > Otherwise, great package. well done! > Please have a look at it after the copyright fix, also I used quilt > instead of dpatch system: > http://mentors.debian.net/debian/pool/main/a/acon/acon_1.0.5-4.dsc Can you also please add the quilt change to the changelog ? > > > thwab-lib: Electronic Encyclopedia System > > > http://mentors.debian.net/debian/pool/main/t/thwab-lib/thwab-lib_1.1.2-1.dsc > > > > This needs extensive checking. I'm a bit busy these days but I'll try to free(some_time) > > Ok. Problem with thwab-lib is we might hit licensing issues. It's also a big package and I'm not that experienced yet ;-) Will free time for it. -- GPG-Key: 0xA3FD0DF7 - 9F73 032E EAC9 F7AD 951F 280E CB66 8E29 A3FD 0DF7 Debian User and Developer. Homepage: www.foolab.org
Attachment:
signature.asc
Description: Digital signature