On Wed, Sep 12, 2007 at 01:51:22PM +0200, Ahmed El-Mahmoudy wrote: > as-salamu alaykom, > > Can anyone (Mohammed Sameer or Mohammed Adnene ?) please review and > upload those packages: > > acon: Text console arabization > http://mentors.debian.net/debian/pool/main/a/acon/acon_1.0.5-4.dsc I have 2 small questions/notes: in the copyright file you have: Upstream Author: Ahmed Abdel-Hamid Mohamed <ahmedam at mail dot usa dot com> License: Copyright (C) 1999-2000 Kristian Gunstone <kristian dot gunstone at pean dot org> it doesn't state that the work is copyrighted Ahmed Abdel-Hamid Mohamed ? Who is Kristian Gunstone ? Why is he mentioned ? The 2nd thing: Why are you Using install -m 4755 instead of dpkg-override to set setuid for acon. ? Otherwise, great package. well done! > thwab-lib: Electronic Encyclopedia System > http://mentors.debian.net/debian/pool/main/t/thwab-lib/thwab-lib_1.1.2-1.dsc This needs extensive checking. I'm a bit busy these days but I'll try to free(some_time) -- GPG-Key: 0xA3FD0DF7 - 9F73 032E EAC9 F7AD 951F 280E CB66 8E29 A3FD 0DF7 Debian User and Developer. Homepage: www.foolab.org
Attachment:
signature.asc
Description: Digital signature