Re: [PATCH] MPlayer Subtitles Arabic Shaping Support

[Behdad Esfahbod <behdad at cs dot toronto dot edu>]

On Wed, 2 Jun 2004, Mohammed Yousif wrote:

> On Thursday 03 June 2004 03:14, Behdad Esfahbod wrote:
> > Hi,
> >
> > I'm completely against this patch which imports Arabic specific
> > code into the mplayer code base.
>
>   And What about Hebrew specific code which is already imported
>   into mplayer code base? (search for 'hebrew' on subreader.c)
>   There is even an "almost" hard-coded encoding specification
>   there (ISO-8859-8).
>   Also, note that Arabic is used by much more people than
>   Hebrew.

I don't care much about Hebrew code, but Arabic code is specially
important to me.

> > The functionality is going to
> > be implemented in GNU FriBidi instead, and that's the place it
> > belongs too.
> >
> > The GNU FriBidi with Arabic Joining/Shaping support will be
> > released this month.
>
>   This is good news.
>
> > If you don't buy my promise on the release
> > time, go on and add shaping support to FriBidi, but not mplayer
> > please.
> >
> >
> > Behdad Esfahbod
> > GNU FriBidi maintainer
>
>   Not sure what do you mean, I already asked you about that
>   months ago (maybe a year?) and you said "Thanks, I will
>   let you know when work on shaping start" but never heard anything
>   else from you.

Well, you're right.  By this I just meant that my laziness is not
a stopper for other people.  People are always welcome to add
their joining support.  BTW, this is a non-issue now, since I'm
really finishing up the code.

>  Anyway, I see it this way "Arabic shaping with code outside of FriBiDI
>  is much better than no Arabic shaping at all".

I was shocked, since I never heard on Arabeyes from you doing
this thing.


--behdad
  behdad.org