Re: [PATCH] MPlayer Subtitles Arabic Shaping Support

[Mohammed Yousif <mhdyousif at gmx dot net>]

On Thursday 03 June 2004 04:56, Behdad Esfahbod wrote:
>
> I don't care much about Hebrew code, but Arabic code is specially
> important to me.
>

 The problem is that you used the phrase "which imports Arabic specific
 code into the mplayer code base" to convince people that this patch
 shouldn't be merged with mplayer code while it is apparent that
 mplayer doesn't have such policy and might accept more lang-specific
 code.

>
> Well, you're right.  By this I just meant that my laziness is not
> a stopper for other people.  People are always welcome to add
> their joining support.

 The question is, would have you accepted a patch to FriBiDI?
 I'm sure there are a few good shaping code out there but you didn't
 try to use them so why would you accept a patch from someone?
 My perception is that you think that current shaping engines are not
 good enough.

> BTW, this is a non-issue now, since I'm 
> really finishing up the code.
>

 Great, can we expect a release this month?

> >  Anyway, I see it this way "Arabic shaping with code outside of FriBiDI
> >  is much better than no Arabic shaping at all".
>
> I was shocked, since I never heard on Arabeyes from you doing
> this thing.
>

 Why the shock? and why "this thing" attitude? Did I do something wrong?
 
 This "thing" has been on my HD for quite a while now (3 months I think),
 but it was only yesterday that I had had some time to grab the latest CVS
 Head of mplayer and send the patch against it.

 This is why you "never heard" about it in Arabeyes :-)
 (Am I supposed to tell people about every little "thing" I make even
  before it's complete?)

 But I still see no problem in this patch, if FriBiDI didn't get shaping,
 the patch will be useful and if FriBiDI got shaping then removing
 the patch and using FriBiDI is less than a five-minutes job (It may even
 be easier to use FriBiDI shaping when this patch is applied)

>
> --behdad
>   behdad.org

-- 
Mohammed Yousif
Egypt