Re: [PATCH] MPlayer Subtitles Arabic Shaping Support

[Behdad Esfahbod <behdad at cs dot toronto dot edu>]

Hi,

I'm completely against this patch which imports Arabic specific
code into the mplayer code base.  The functionality is going to
be implemented in GNU FriBidi instead, and that's the place it
belongs too.

The GNU FriBidi with Arabic Joining/Shaping support will be
released this month. If you don't buy my promise on the release
time, go on and add shaping support to FriBidi, but not mplayer
please.


Behdad Esfahbod
GNU FriBidi maintainer



On Wed, 2 Jun 2004, Mohammed Yousif wrote:

> Hello,
>   Attached is a patch to enable Arabic language support.
>   Currently, FriBiDI does BiDI, but Arabic also needs shaping.
>   Shaping is the process of "connecting" the letters to form new
>   shapes depending on the position of a given Arabic letter.
>
>    + A screenshot of MPlayer without the patch:
>         http://mhdyousif.host.sk/files/mplayer_without_shaping.jpg
>
>    + A screenshot of MPlayer with the patch:
>         http://mhdyousif.host.sk/files/mplayer_with_shaping.jpg
>
>   The patch is, FYI, here too:
>     http://mhdyousif.host.sk/files/mplayer_arabic_shaping.patch
>
>   Thanks,,
>

--behdad
  behdad.org