On Tue, Nov 12, 2002 at 10:31:30AM +0000, Phactorial - wrote: > I no longer have that "specific" patch. Give me more details on which patch > this is so I can dig it back up. I changed that "statement" because it was > inside a if block I think. I created a PR for it on http://www.arabeyes.org/arabugs -- akka/54 > > What is the point of doing if(keystroke=0)? Re-read your own patch ;) > That will always return true. I think that patch was not mostly cosmetic > (my earlier patches were, and had some added optimizations and some > organization fixes [many parts of the original Akka codebase are > illogical]). However, my later patches were mostly oriented in fixing your > redundant FreeBSD ifdef and adding some more portability to the unportable > Akka. I could not find much on the FreeBSD font related and screen > orientation IOCTLs (that is, ones that provide the same unfunctionality as > the, I think, PG* ioctls). However, Akka still needs a complete rewrite, > which I am still pondering of doing (rather than adding the insert > functionality you requested for Farsi). > I don't know if we are talking about different things, but the majority of the patch seemed to be code beautification. Do check if I have the right one, it's attached to akka/54 > Regarding that e-mail that was due for Saturday: > Farsi is a pretty well written piece of work (still space for > optimizations, maybe some architecture overhauls (some server exception > handling to allow the changing of options on the fly), portability seems to > be trivial here fortunately). However, the BSD license is not something > that I take favorably for large projects, a lot of the changes made to the > code are simply redistributed in other programs rather than donated back to > the project (working on our revised Akka will allow us to maintain the GPL). I guess we both have differences (as well as everyone here) on how we perceive licenses. I don't have any problem with the BSD license (I obviously am using it for Duali) -- so I am treating this from a purely technical perspective. In either case, I don't see this as the kind of project where the license really matters. There is only so much you can add to it. later -- ------------------------------------------------------- | Mohammed Elzubeir | Visit us at: | | | http://www.arabeyes.org/ | | Arabeyes Project | Homepage: | | Unix the 'right' way | http://fakkir.net/~elzubeir/| ------------------------------------------------------- --- Was I helpful? Let others know: http://svcs.affero.net/rm.php?r=elzubeir
Attachment:
pgp00015.pgp
Description: PGP signature