[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Akka patch

I no longer have that "specific" patch. Give me more details on which patch this is so I can dig it back up. I changed that "statement" because it was inside a if block I think.

What is the point of doing if(keystroke=0)?
That will always return true. I think that patch was not mostly cosmetic (my earlier patches were, and had some added optimizations and some organization fixes [many parts of the original Akka codebase are illogical]). However, my later patches were mostly oriented in fixing your redundant FreeBSD ifdef and adding some more portability to the unportable Akka. I could not find much on the FreeBSD font related and screen orientation IOCTLs (that is, ones that provide the same unfunctionality as the, I think, PG* ioctls). However, Akka still needs a complete rewrite, which I am still pondering of doing (rather than adding the insert functionality you requested for Farsi).



Regarding that e-mail that was due for Saturday:
Farsi is a pretty well written piece of work (still space for optimizations, maybe some architecture overhauls (some server exception handling to allow the changing of options on the fly), portability seems to be trivial here fortunately). However, the BSD license is not something that I take favorably for large projects, a lot of the changes made to the code are simply redistributed in other programs rather than donated back to the project (working on our revised Akka will allow us to maintain the GPL).

I recommend that you do one thing, forget about me and Farsi. Give me a couple of weeks to ponder about Akka and the way to go for the rewrite. I will contact you as much as possible with my ideas, comments, etc... In a good amount of time we should have a completely new design sketch for Akka for us to get down and dirty into hacking out new code.






From: Mohammed Elzubeir <elzubeir at arabeyes dot org>
Reply-To: developer at arabeyes dot org
To: developer at arabeyes dot org
Subject: Akka patch
Date: Mon, 11 Nov 2002 08:18:37 -0600
MIME-Version: 1.0
Received: from mc1-f8.law16.hotmail.com ([65.54.236.15]) by mc1-s6.law16.hotmail.com with Microsoft SMTPSVC(5.0.2195.5600); Mon, 11 Nov 2002 06:24:00 -0800
Received: from arabeyes.org ([66.169.211.190]) by mc1-f8.law16.hotmail.com with Microsoft SMTPSVC(5.0.2195.5600); Mon, 11 Nov 2002 06:23:59 -0800
Received: from arabeyes.org (arabeyes [127.0.0.1])by arabeyes.org (Postfix) with ESMTPid 22321EF74; Mon, 11 Nov 2002 08:19:03 -0600 (CST)
Received: by arabeyes.org (Postfix, from userid 1000)id 1745EEF72; Mon, 11 Nov 2002 08:18:37 -0600 (CST)
Delivered-To: developer at arabeyes dot org
Message-ID: <20021111141837 dot GA11636 at arabeyes dot org>
User-Agent: Mutt/1.4i
Sender: developer-admin at arabeyes dot org
Errors-To: developer-admin at arabeyes dot org
X-BeenThere: developer at arabeyes dot org
X-Mailman-Version: 2.0.13
Precedence: bulk
List-Help: <mailto:developer-request at arabeyes dot org?subject=help>
List-Post: <mailto:developer at arabeyes dot org>
List-Subscribe: <http://arabeyes.org/mailman/listinfo/developer>,<mailto:developer-request at arabeyes dot org?subject=subscribe>
List-Id: Development Discussions <developer.arabeyes.org>
List-Unsubscribe: <http://arabeyes.org/mailman/listinfo/developer>,<mailto:developer-request at arabeyes dot org?subject=unsubscribe>
List-Archive: <http://arabeyes.org/archives/developer/>
Return-Path: developer-admin at arabeyes dot org
X-OriginalArrivalTime: 11 Nov 2002 14:24:00.0098 (UTC) FILETIME=[FA353420:01C2898D]


Salam Samy,

Today morning I spent some time looking through the patch you sent for Akka
some time back. It is largely cosmetic (but changes aren't bad) -- however,
there are things that I'm not sure what you were thinking about ;)

379 render.c -- you are replacing it with keystroke==0 ?

That's not a conditional, it's a statement. So why would you do that? In any
case, the patch is 'malformed' or generally 'patch' doesn't like it, so please
resend (via gnats http://www.arabeyes.org/arabugs).

Thanks
--
-------------------------------------------------------
| Mohammed Elzubeir    | Visit us at:                 |
|                      |  http://www.arabeyes.org/    |
| Arabeyes Project     | Homepage:                    |
| Unix the 'right' way |  http://fakkir.net/~elzubeir/|
-------------------------------------------------------
---
Was I helpful? Let others know:
http://svcs.affero.net/rm.php?r=elzubeir
<< attach3 >>


_________________________________________________________________
Protect your PC - get McAfee.com VirusScan Online http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963