[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Katoob ver 0.3.0 Released



lör 2002-09-14 klockan 01.33 skrev Mohammed Sameer:
> Arabeyes would like to announce the release of Katoob version 0.3.0

Woho!

As a user of as swedish keyboard, I really like the arabic keyboard
emulator! 

Attached is a patch that changes the text direction buttons to use radio
buttons. There is also a swedish translation of Katoob attached.


In the swedish translation I have changed the following text quite
dramatically:

From

    An error has occured while trying to initialize your Arabic
    keyboard, Katoob'll try to use the built in Arabic keyboard
    emulator.
    
To (translated from swedish)

    You don't have an Arabic keyboard. Katoob will try to use the
    built-in Arabic keyboard emulator instead.
    
If it's ok, I hope you will replace the original text to.


I would like to change the language selection button to be a toggle
button, with a tooltip like "Use arabic keyboard emulation". The current
implementation is a bit confusing.  What happens if you press this
button and you do have an arabic keyboard?


>  * Enabling/Disabling, Limiting the size of the Undo history

Do a user really need to tweak this setting? I suggest setting it to
something high, like 1000, and remove it from the gui.


>  * Limiting the size of the Recent documents menu

Like above. The current implementation allows an unlimited document
history if you set the size to 0. That might cause problems after a
while...


What is the difference betwen "UTF-8" and "Plain UTF-8 text" in the save
dialog?


	-Jens

Attachment: sv.po
Description: application/po

Index: src/main.c
===================================================================
RCS file: /home/CVS/projects/katoob/src/main.c,v
retrieving revision 1.58
diff -u -r1.58 main.c
--- src/main.c	10 Sep 2002 05:30:52 -0000	1.58
+++ src/main.c	14 Sep 2002 17:06:35 -0000
@@ -205,6 +205,9 @@
   GtkWidget *menubar;
   GtkWidget *ev;
   GdkPixbuf *icon;
+  GtkWidget *stock_icon;
+  GtkWidget *button;
+  GSList *direction_group = NULL;
   gint x;
   extern GHashTable *emu;
   katoob_debug(__FUNCTION__);
@@ -319,14 +322,33 @@
 			   _("Delete current selection"), NULL,
 			   G_CALLBACK(katoob_delete), katoob->mainwindow, -1);
   gtk_toolbar_append_space(GTK_TOOLBAR(katoob->toolbar));
-  gtk_toolbar_insert_stock(GTK_TOOLBAR(katoob->toolbar),
-			   GTK_STOCK_JUSTIFY_LEFT,
-			   _("Left to right direction"), NULL,
-			   G_CALLBACK(katoob_ltr), katoob->mainwindow, -1);
-  gtk_toolbar_insert_stock(GTK_TOOLBAR(katoob->toolbar),
-			   GTK_STOCK_JUSTIFY_RIGHT,
-			   _("Right to left direction"), NULL,
-			   G_CALLBACK(katoob_rtl), katoob->mainwindow, -1);
+
+
+  stock_icon = gtk_image_new_from_stock ("gtk-justify-left",
+					 gtk_toolbar_get_icon_size (GTK_TOOLBAR(katoob->toolbar)));
+  button = gtk_toolbar_append_element (GTK_TOOLBAR(katoob->toolbar),
+				       GTK_TOOLBAR_CHILD_RADIOBUTTON,
+				       NULL,
+				       _("Left to right direction"),
+                                       _("Left to right direction"),
+				       NULL,
+				       stock_icon,
+				       G_CALLBACK(katoob_ltr), katoob->mainwindow);
+  gtk_radio_button_set_group (GTK_RADIO_BUTTON (button), direction_group);
+  direction_group = gtk_radio_button_get_group (GTK_RADIO_BUTTON (button));
+
+  stock_icon = gtk_image_new_from_stock ("gtk-justify-right",
+					 gtk_toolbar_get_icon_size (GTK_TOOLBAR(katoob->toolbar)));
+  button = gtk_toolbar_append_element (GTK_TOOLBAR(katoob->toolbar),
+				       GTK_TOOLBAR_CHILD_RADIOBUTTON,
+				       NULL,
+				       _("Right to left direction"),
+                                       _("Right to left direction"),
+				       NULL,
+				       stock_icon,
+                                       G_CALLBACK(katoob_rtl), katoob->mainwindow);
+  gtk_radio_button_set_group (GTK_RADIO_BUTTON (button), direction_group);
+
   gtk_toolbar_append_space(GTK_TOOLBAR(katoob->toolbar));
   gtk_toolbar_append_widget(GTK_TOOLBAR(katoob->toolbar), katoob->xkb,
 			    _("Change the typing language"), NULL);