RE: [Fribidi-discuss] fribidi & arabic shaping

[Nadim Shaikli <shaikli at yahoo dot com>]

On 03/21/2002 04:21:52,
  Behdad Esfahbod wrote:
> 
> I think that by enable_shaping_options Nadim means to turn on or 
> off the shaping, AFAIK shaping has no options.

That is indeed what I meant (and I even wrote boolean instead of int
early on), but then thought that this option ought to be expandable
just in case (for any potential bug work-arounds, application issues,
etc -- no harm done, use this 'int' as a 1/0 and/or TRUE/FALSE :-)

> And we do not need the help for this, we have the tested code,
> I should just merge them.

OK - I'll keep checking the release announcements for it.

>
> behdad
> 
> On Thu, 21 Mar 2002, Omer Zak wrote:
> 
> > On Wed, 20 Mar 2002, Nadim Shaikli wrote:
> > 
> > > Behdad, I'm assuming by "joining" you mean shaping ?  If so, could you
> > > please include a flag to whether you want that enabled or not as part of
> > > the interface (for backward compatibility & in the cases the application
> > > is doing its own) ?
> > > 
> > > ie. something along the lines of,
> > > 
> > >  void
> > >  fribidi_log2vis(/* input */
> > 
> > There is also FriBidiEnv* parameter.
> > 
> > >                  FriBidiChar     *str,
> > >                  int              len,
> > >                  FriBidiCharType *pbase_dir,
> > >                  int              enable_shaping_options,     <--- NEW
> > >                  /* output */
> > >                  FriBidiChar *visual_str,
> > >                  gint        *position_L_to_V_list,
> > >                  gint        *position_V_to_L_list,
> > >                  gint8       *embedding_level_list
> > >                 )
> > > 
> > > If there are issues with the shaping implementation, I have no problem
> > > helping/implementing simply as an incentive and indication of its
> > > importance to the Arabic community at large.
> > 
> > The FriBidiEnv data structure has enough unassigned flags to
> > accommodate the shaping options.

Sorry I wasn't able to find any info on FriBidiEnv (haven't looked into CVS,
which is where I think it is), but if that is an environmental variable that
a user ought to set, I would still suggest implementing a function variable
as is noted above (ie. the NEW part above) to give the application ultimate
control.  If its a struct, on the other hand, that's encompassed/controlled
internally then great (the "Env" part threw me for a loop).

BTW: please don't forget to CC those included.

 - Nadim


__________________________________________________
Do You Yahoo!?
Yahoo! Movies - coverage of the 74th Academy Awards®
http://movies.yahoo.com/