Re: DrakX translation update

[Ossama Khayat <okhayat at yahoo dot com>]

--- Youcef Rabah Rahal <y dot rahal at gmail dot com> wrote:
> Salam,

Salam,

> I was about to sync and then... I noticed a few issues:
> 
> 1- You used CVS_SILENT to commit a lot of files (I really thought it
> was only DrakX that you committed).

Sorry. It was a commit after OOo updated (which was done silently because of so
much directories), and I forgot to remove the SILENT option.

> 2- There are serious problems with some commits (I do systematic diffs
> with every time there's a commit). To be honest I noticed one problem
> and I did not check further if it was also there with other files:
>
http://cvs.arabeyes.org/viewcvs/translate/mandrake/userdrake.po.diff?r1=1.13&r2=1.14&sortby=date

hmm.. not sure what the problem is. Is it the header or what? I wouldn't have
known what's the problem even if I used a diff ;-)

> So what I suggest is:
> 
> 1- Please do not use CVS_SILENT to commit your files unless your are
> committing multiple files in multiple directories. In the case of Mdk,
> there's only one dir, so there will be one notifcation email sent out,
> even if there are change to all the files of the dir.

Sure.

> 2- Please check your commit by doing a diff. You can do so by using
> 'cvs diff filename' _before_ you commit. But you can also use the
> ViewCVS interface _after_ you commit to check that everything is OK
> (as long as you fix the issues if you find any ;-)

It could be that I didn't cvs update before committing.

> That's it ;-) Could you please check and fix the files so I can do the
> sync. There is not anyway a big hurry since there won't be a
> translation freeze before RC1.

I'm really not sure at all how to fix it. So, can we just do the sync now and
I'll review the changes again?

- Ossama

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com