[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PuTTY Testing



--- ahmad khalifa <ahmadkhalifa hotmail.com> wrote:
>From: Nadim Shaikli <shaikli yahoo.com>
>
> >Here are a few things I've encountered that I think should be fixed
> >before we push for the patch's adoption.
> >
> >  1. Do some repetitive 'ls -lF' and 'clear', putty crashed on me a
> >     number of times (there might be a memory leak somewhere).
> 
> did u try that in an ordinary putty (without my patch) ??
> i'll try to reproduce that crash.

Yup, this crash only happens with the patch applied.  The point here
I guess is to stress its redraw functions and I believe there is a
leak within somewhere.

> I couldnt reproduce Number 1. the ls -lF and clear thing. did it
> a few times and everything was OK.

You might need to do it 10-15 times (it differs for me each time).
 
> there is some leak though. putty's mem consumption keeps rising
> in the Task Manager.

There you go :-)
 
> >  2. If you view that favorite test file 'ar_utf8' there is a string
> >     in there that notes, "Here are some Random words:" for whatever
> >     reason the ":" dances around and changes location.  'cat' the
> >     file (or less it) and then scroll back to that line (towards
> >     the top to see what I mean).
> 
> hmm, you're really good at finding these things. maybe u shouldnt
> be testing PuTTY. :)))

Hehehe - I'm just bewildered at why the others are so silent and not
even testing (a shame to say the least).  I believe the least a person
can do, if he/she aren't developing, is to give feedback to keep busy
people on-track and progressing.

> >      http://arabeyes.org/~nadim/ar_utf8
> >
> >     BTW: that line is not shown correctly (ie. I don't think Bidi
> >          is doing the right thing there.
> 
> I dont see the problem with the line "here are some random..."
> this is exacly how its layed out in my PuTTY...
> 
>   :-- Here are some Random Words 3ashwa2eya Kalimat
> 
> is that the correct way? IE and NS do totally different ordering...

I'd suggest you revert to pipe'ing the data through fribidi or use
mlterm on your linux box.

The line should look like this (per what one would expect),

  :Here are some Random words -- 3ashwa2eya Kalimat

> >  3. The LAM+ALEF which gets combined into a LAA still exhibits a
> >     space after it.  That space should really be visually gone.
> 
> i could shift the rest of the line to override the space, but will this
> be OK with the cursor and stuff?

I'm not really sure, it would be best to have Simon look into how to
deal with this, but I doubt we'll get any of his help anytime soon
(if history is an indicator) - so see what options/avenues exist and
at a min keep 'em in mind.  This issue will need to be solved first
and foremost before tackling any of the other harder topics.

> >  4. Do please add 2 buttons in Terminal->Features that notes,
> >     a. Disable Shaping
> >     b. Disable Bidi
> 
> OK. but i'll keep them in a separate patch for now. just to be safe.

No need for a separate patch, those buttons will be needed in case
someone wants to disable parts or the entire patch.  It is also a
useful thing to have for various debug type of issues.

> > > anyway, i tested it and seem to get 100% Bidi Compliance,
> > > anyone care to correct me ?
> >
> >The visual look of raw data looks semi-clean (note above).
> >I think once things are settled looking into Control-Characters
> >will be warranted in order to properly place cursors and/or string
> >search boxes, etc (that's for much later on).
> 
> i did run the tests, didnt u see the screen shots ??  i only added
> mirroring code to it after the screen shots...

Oops, I didn't see it.  You mean,

  http://art.arabeyes.org/external/putty1

Well there are obvious differences in your output as compared to the
'Unicode Reference Code' output in the table listed in,

  http://crl.nmsu.edu/~mleisher/ucdata.html

Will you be addressing those differences ?

> btw: i really hate the mirroring function, any hints there.?

I'm unsure to what you need mirroring since Bidi is supposed to take
care of everything, but then again I gather this might be a PuTTY
forced issue or something.

> nadim: umm, you mentioned before something about the last
> line, what was it??? cuz i see some strange breaking there...

Yeah, its that strange line breaking is what I noted :-)  Check the
'developer' archives.

Salam.

 - Nadim


__________________________________
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.
http://taxes.yahoo.com/filing.html