Re: patch - rightleft in command-line

[Nadim Shaikli <shaikli at yahoo dot com>]

--- Bram Moolenaar <Bram at moolenaar dot net> wrote:
> 
> Nadim Shaikli wrote:
> 
> > Attached you'll find a patch (against vim-6.0 vanilla) that introduces
> > rightleft search (ie. '/') ability in rightleft mode to the command-line.
> 
> Thanks for making this!  I'll keep the patch for a while, until I get
> some response from people who use it (and I'm currently only doing bug
> fixes).
> 
> A few remarks about what I noticed when browsing through it:
> 
> - The "msg_rl" variable should not really be there when FEAT_RIGHTLEFT
>   isn't defined.

OK - I'll look into that.

> - "firstc" should also be checked for "?".

Ah, I knew I forgot something - I think I added it early on and that
for some reason generated some weird behavior which I opted not to look
into at that instance and then simply forgot to go back and address it :-)
 
> > While doing this (and I had wanted to add substitution in rightleft
> > mode as well), I become utterly convinced that Bidi is a MUST and
> > should really be considered as a replacement for rightleft all together.
> > So I decided to spend whatever time I can on Bidi instead of adding
> > more features to rightleft (Arabic patch coming though :-)
> 
> A more generic solution would be preferred.  I wonder if the current
> 'rightleft' should be kept, so that the user can still chose to use it,
> or that the Bidi feature would completely replace it.

Bidi should completely replace rightleft since it will "do the right
thing" based on the character encodings in my opinion.  I can't
envision the need for 'rightleft' if Bidi was implemented.
Mono-directionality in a right-to-left language is very limiting
since most users will opt to include some left-to-right (English,
French, Spanish, etc) text.

 - Nadim


__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com