[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] MPlayer Subtitles Arabic Shaping Support
- To: Development Discussions <developer at arabeyes dot org>
- Subject: Re: [PATCH] MPlayer Subtitles Arabic Shaping Support
- From: Mohammed Yousif <mhdyousif at gmx dot net>
- Date: Thu, 3 Jun 2004 18:56:15 +0300
- User-agent: KMail/1.6.1
On Thursday 03 June 2004 14:48, Ahmad Khalifa wrote:
> Good job there.
> the screen shots look really cool.
> will the patch be included officially ?
Thanks, I don't know if it will be included or not (given the new information
from Behdad about shaping in FriBiDI) but even if it is not, not a big deal
because it already achieved its goal (I really needed it for some other
purpose not related to Arabeyes).
And yes, it will help as a motivator for Behdad to get the shaping code
done ASAP :-)
> btw, i took a look at the patch, im guessing that your shaping
> breaks on transparent chars (a.k.a NSM). you might want to look into
> if you need any help, i'll be around...
How is that?
About 1/4 of this code is for handling transparent characters :-)
But if you mean transparent characters not in ISO-8859-6, then
yes, it will not shape but this is not bad because it makes less sense
to use a transparent character not in ISO-8859-6 inside an Arabic word
and still expect it to shape (umlaut, for example, shouldn't be inside
an Arabic word and if the user added it there then he/she shouldn't
expect it to shape GI/GO :-)
But if you mean another thing, can you please give me a sample?
There is another issue (but not related to the shaping code).
It's that mplayer draws transparent characters with their own
width and thus causes any Arabic word that has harakat to be
disconnected a bit for every haraka (but still shaping is correct).
I didn't bother fixing that anyway because it is only a subtitle.
> btw, i got Mandrake-10 CDs, want 'em ?? i can come to zagazig again :-))
You can come to Zagazig again? hehehe, you are a very strange person :-)
It will be more logical if I come to Cairo and take 'em. I use Slackware but
I still need Mandrake 10 because people ask for it here.
Thanks, I will let you know when I decide to go to Cairo.