Fwd: [Bug 1404]: call for Arabic testers

[Munzir Taha <munzirtaha at newhorizons dot com dot sa>]

Good news! Some improvement in the LyX issue. I am going to test within 24h 
and give feedback Inshallah. I know it's shameful to wait for 11 days before 
testing. Alas!

----------  Forwarded Message  ----------

Subject: [Bug 1404]: call for Arabic testers
Date: Friday 28 November 2003 13:14
From: Angus Leeming <leeming at lyx dot org>
To: lyx-users at lists dot lyx dot org
Cc: Munzir Taha <munzirtaha at myrealbox dot com>

Guys, I attach a patch for bug 1404

doublespace is messed in a single Arabic paragraph

LyX wil currently generate LaTeX like:

\begin{document}
\begin{doublespace}
\begin{arabtext}
...
\end{doublespace}
\end{arabtext}
\end{document}

Ie, the \end{doublespace} and \end{arabtext} lines are output in the wrong
order.

I posted the patch originally on 17 November in reply to Munzir Taha's mail
 on the subject. It would be nice if I could get this out of the 'pending'
 tray and into the sources, but I first need someone to test it.

Please try it out and see if it fixes the problem...

--
Angus

-------------------------------------------------------



-- 
  __/    __/          _/  _/  _/
 _/ _\  _/ _\            _/
_/    \ /   _\ unzir    _/ aha	PGP Key available
gpg --recv-keys --keyserver www.mandrakesecure.net F0671821

Telecommunications and Electronics Engineer
Linux Registered User #279362 at http://counter.li.org
Mandrake Club member
Maintainer of Mandrake Arabization Project Status (MAPS)
http://www.arabeyes.org/download/documents/distro/mdkarabicsupport.html
CIW Designer, ICDL, MOUS
New Horizons CLC
Riyadh, SA

Index: src/paragraph.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/paragraph.C,v
retrieving revision 1.235.2.1
diff -u -p -r1.235.2.1 paragraph.C
--- src/paragraph.C	12 Feb 2003 21:01:18 -0000	1.235.2.1
+++ src/paragraph.C	18 Nov 2003 10:43:07 -0000
@@ -1154,12 +1154,6 @@ Paragraph * Paragraph::TeXOnePar(Buffer 
 			os << '\n';
 			texrow.newline();
 		}
-
-		if (!params().spacing().isDefault()
-			&& (!next_ || !next_->hasSameLayout(this))) {
-			os << params().spacing().writeEnvirEnd() << '\n';
-			texrow.newline();
-		}
 	}
 
 	// we don't need it for the last paragraph!!!
@@ -1182,6 +1176,14 @@ Paragraph * Paragraph::TeXOnePar(Buffer 
 					    "$$lang",
 					    language->babel())
 				   << endl;
+			texrow.newline();
+		}
+	}
+
+	if ((in == 0) || !in->forceDefaultParagraphs(in)) {
+		if (!params().spacing().isDefault()
+			&& (!next_ || !next_->hasSameLayout(this))) {
+			os << params().spacing().writeEnvirEnd() << '\n';
 			texrow.newline();
 		}
 	}