[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libitl-0.6.4 :A possible BUG? C# porting almost complete!



Meor Ridzuan Meor Yahaya writes:
 > Dear All,
 > 
 > I was working on porting libitl to C# to make it run on .net platform
 > . Right now I'm almost done with prayertime . I'll be working on hijri
 > date converter later.
 > 

While I could count almost 10 other ports of libitl, none of them are
with us today ;-) Also, since I sometimes receive emails asking for
such code, I think It's a good idea to have a well maintained port
included within the ITL project (or somewhere to point others to).

 > During my work, I've found a possible bug. In astro.h, it has the
 > following definition:
 > 
 > #define DEG_TO_RAD(A) (A * (PI/180.0))
 > 

Thanks, Meor, Tarik. The above is definitely a bug.

The large difference in minutes is caused by another bug,
however. That bug is not related to the missing parentheses problem,
but it was only made hidden by it. I fixed both bugs, and now I can
only see every-other-day differences of 1 minute compared to the 0.6.4
release (it's actually a lot less than 1 minute, but I assume rounding
to the nearest minute).

Both bugs are now fixed in CVS. If you still see a large difference
even after applying the fix, please provide some input/output numbers
to allow me to reproduce it.

Salaam and thanks,
Thamer Mahmoud