Re: final putty testing

[Nadim Shaikli <shaikli at yahoo dot com>]

--- ahmad khalifa <ahmadkhalifa at hotmail dot com> wrote:
> For the testers:
> try to Change the shaping and bidi settings in the mid of session.
> try to change the checkboxes in "Terminal/Features".

Works very well except in one instance :-)  If you start PuTTY with
both Shaping and Bidi disabled (ie. boxes are checked) and then you
try to unselect them (ie. enable either feature), PuTTY crashes on
ya.  I'm guessing you are not allocating memory except upon frame
invocation (ie. window startup) and so the enabling of the feature
tramples on some memory or something.  Alas, something to debug.

> >From: Nadim Shaikli <shaikli at yahoo dot com>
> 
> >I, like Elzubeir, still see that dancing ":".  It doesn't
> >consistently exhibit the dance feature :-) though.  I've found
> >that if you highlight various text from within 'less' it sometimes
> >forces a dance.
> 
> check it again, it should be fixed...

Yup, it very much is :-)  Great work the bug is gone !!

Anyone else confirm ?

> >and in some instances the ':' goes back to its wrong location and
> >thus the dancing.
> 
> similar to what _used_ to happen with me. i didnt see it before
> because it doesnt occur in the debug version of putty, which i use...

Hehe, you should always test/check that which the user uses :-)
No big - at least you got it now.

> >Do please look into cut-n-paste issues.  In other words, if I highlight
> >a word on a RTL line and then paste it somewhere, I don't get what I
> >expect (I thought this worked before, but I could be wrong).  In any
> >regard, give it a try and see if you can highlight some single random
> >words and paste them correctly (my guess is that the cut-n-paste code
> >doesn't take Bidi into consideration).
> 
> im guessing that copy-paste should Not work unless you invert your
> selection so if you want to select the first arabic word on a right
> aligned line, you would select the first few chars from the left.

Hehehehee - I don't think any sane person is expected to do that and
actually get it right.  This needs to be fixed and I'm guessing the
selection code is simply not being passed through the Bidi code
(in other words, it doesn't know that things have shifted).  This bug
would be in the same category as the 'space after LAA' bug - if it
is too difficult to tackle, we'll have to bug Simon about it and get
his feedback.

> please confirm if the bug is gone, so we (probably just you) can ping 
> simon..

Its gone, gone, gone :-)  Let me know when you fix the crash noted
above and what you'll do (if anything) regarding cut-n-paste, then
upload all your changes to Arabeyes' CVS as a single .patch file
and we'll ping Simon for inclusion.

If we were 90% done, we are not 95% done ;-)

Salam.

 - Nadim


__________________________________
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.
http://taxes.yahoo.com/filing.html