[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [emacs-bidi] Re: Please help with the bidi Emacs



From: "Eli Zaretskii" <eliz at gnu dot org>
> From: "ahmad khalifa" <ahmadkhalifa at hotmail dot com>
> Date: Sat, 24 Apr 2004 20:53:16 +0000
>
> well, i took a quick look at bidi_resolve_neutral() (from the stack above) ,
> and this block doesnt really look nice. needs some more parenthesis i think.
>
> if (!(type == STRONG_R
> || type == STRONG_L
> || type == WEAK_BN
> || type == WEAK_EN
> || type == WEAK_AN
> || type == NEUTRAL_B
> || type == NEUTRAL_S
> || type == NEUTRAL_WS
> || type == NEUTRAL_ON))
> abort ();

Can you tell why you think it needs more parentheses?  It basically
says

  if (!(expression))
    abort ();
What's wrong with that, and why would an additional pair of enclosing
parens fix that?


are you sure expression is evaluated correctly ? thats what the parens
are for... 1 month ago i would have never thought that this would be a
problem, but after debugging minibidi line by line, i found out that
sometimes this happens, probably because ' || ' and ' == ' have the same
evaluation priority or something.

anyway, just try it. i'll try it if i get the thing to compile...

What OS and what compiler/version is that? 

im using Fedora Core 1 on i686, i also have RH 8.0, i can install that if
you're sure it'll work. on Fedora, gcc's version is 3.2.2 .


ak.

_________________________________________________________________
Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail