Re: [putty]Bidi + PuTTY - done

[Owen Dunn <owend at chiark dot greenend dot org dot uk>]

Owen Dunn <owend at chiark dot greenend dot org dot uk> writes:

> Nadim Shaikli <shaikli at yahoo dot com> writes:
> 
> > A great deal of what is left requires expert PuTTY knowledge
> > (ie. Simon) so we tried to break things down into smaller pieces to
> > better focus on issues and to try to work out a reasonable schedule
> > (the patch, though, is ready to go and is ready for inclusion).
> > 
> >   http://cvs.arabeyes.org/viewcvs/projects/external/putty/
> 
> Thanks.  That looks mostly sane from a first glance.  I'll try to take
> a closer look this weekend, and doubtless Simon will at some point
> too.

That patch applies cleanly but doesn't build (see compile errors
below).  Also, the minibidi code doesn't seem to be referenced by
anything.

(S)

        cl    /nologo /W3 /O1 /D_WINDOWS /D_WIN32_WINDOWS=0x401 /DWINVER=0x401 /c terminal.c
terminal.c
terminal.c(244) : error C2065: 'wcFrom' : undeclared identifier
terminal.c(244) : warning C4022: 'free' : pointer mismatch for actual parameter 1
terminal.c(245) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *'
terminal.c(246) : error C2065: 'ltemp' : undeclared identifier
terminal.c(246) : warning C4022: 'free' : pointer mismatch for actual parameter 1
terminal.c(247) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *'
terminal.c(248) : error C2065: 'wcTo' : undeclared identifier
terminal.c(248) : warning C4022: 'free' : pointer mismatch for actual parameter 1
terminal.c(249) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *'
terminal.c(445) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *'
terminal.c(446) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *'
terminal.c(447) : warning C4047: '=' : 'int ' differs in levels of indirection from 'void *'
terminal.c(480) : warning C4022: 'free' : pointer mismatch for actual parameter 1
terminal.c(481) : warning C4022: 'free' : pointer mismatch for actual parameter 1
terminal.c(482) : warning C4022: 'free' : pointer mismatch for actual parameter 1
terminal.c(3452) : error C2109: subscript requires array or pointer type
terminal.c(3452) : error C2106: '=' : left operand must be l-value
terminal.c(3457) : error C2109: subscript requires array or pointer type
terminal.c(3457) : error C2106: '=' : left operand must be l-value
terminal.c(3459) : error C2109: subscript requires array or pointer type
terminal.c(3459) : error C2106: '=' : left operand must be l-value
terminal.c(3463) : warning C4013: 'doBidi' undefined; assuming extern returning int
terminal.c(3468) : error C2109: subscript requires array or pointer type
terminal.c(3468) : error C2109: subscript requires array or pointer type
terminal.c(3468) : error C2106: '=' : left operand must be l-value
terminal.c(3471) : warning C4013: 'do_short_shape' undefined; assuming extern returning int
terminal.c(3475) : error C2109: subscript requires array or pointer type
terminal.c(3476) : error C2109: subscript requires array or pointer type
terminal.c(3476) : error C2109: subscript requires array or pointer type
terminal.c(3476) : error C2109: subscript requires array or pointer type
terminal.c(3476) : error C2106: '=' : left operand must be l-value
terminal.c(3478) : error C2109: subscript requires array or pointer type
terminal.c(3478) : error C2109: subscript requires array or pointer type
terminal.c(3478) : error C2109: subscript requires array or pointer type
terminal.c(3478) : error C2106: '=' : left operand must be l-value
terminal.c(3480) : warning C4047: '=' : 'unsigned long *' differs in levels of indirection from 'int '
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.