Re: duali 0.1.1 ?

[elzubeir at arabeyes dot org (Mohammed Elzubeir)]

On Mon, Jul 07, 2003 at 08:01:38AM +0300, Mohammed Sameer wrote:
> They are ready!
> 
> duali-data_0.1b-1_all.deb "db files"
> pyduali_0.1.1-1_all.deb "the main duali things"
> duali-tools_0.1.1-1_all.deb "dict2db.py"
> 
Where? ;)

> i had to do some changes to pyduali:
> 1- aralex.py & trans_table.py: removed the !#/usr/* line

Oh.. okay <shrug>.. that should have been part of the code-cleanup ;)

> 2- all the other scripts: changed #!/usr/bin/env python to 
>    #!/usr/bin/python2.2

That's not necessary.. the code checks for the python version.

> 3- setup.py:
> 	-      data_files = [ ('/etc', ['duali.conf']) ],
> 	+      data_files = [ ('etc', ['duali.conf']) ],
> 	-      scripts= ['duali.py', 'trans2arabic.py', 'dict2db.py'])
> 	+      scripts= ['duali.py', 'trans2arabic.py'])

2 things:
  1. Why are you removing the dict2db.py from scripts?
  2. These changes are fine for the deb pkg, but they are not something
  I would put in the actual cvs version.

> 4- duali.py:
> 	@@ -21,7 +21,8 @@
> 	 #---
> 	 
> 	 import sys, getopt, os, ConfigParser
> 	-import pyduali.aradict, pyduali.aralex, pyduali.araspell
> 	+sys.path.append('/usr/lib/python2.2/site-packages/pyduali')
> 	+import aradict, aralex, araspell
> 	 #from pyduali.arabic import *

Should not do that. The whole point of the pyduali package is that you
don't do that. You should not append that path, since
.../python2.2/site-packages/ is automatically there (hence the
pyduali.modulename).

I uploaded the tarball again with the __init__.py file (which should
solve this problem).

> 5- trans2arabic.py
> 	@@ -27,7 +27,8 @@
> 	 #---
> 	 
> 	 import sys, getopt, os, string
> 	-from pyduali.trans_table import *
> 	+sys.path.append('/usr/lib/python2.2/site-packages/pyduali')
> 	+from trans_table import *

Again.. unnecessary (and wrong) ;)

> 6- i renamed pyduali.foo in duali.py to foo directly
> 

Yes.. fix the stuff above first.. and this won't be necessary.

> Flame me for 4, 5 and 6 as you want, but duali.py didn't work except 
> with thoose changes "working fine here".
> 
> I've created 3 man pages for dict2db.py, duali.py and trans2arabic.py
> I'll attach them later or create a bugzilla bug report.

Oh.. I most certainly would like to see the manpages.. attach them to
a bug report on bugzilla, please ;) 

> but I have to get some sleep, It's 7:46 am now :-/
> 

Well if you are awake still.. get on irc, we can get the rest of this
resolved on the spot. Sorry I missed you, was reading other mail while
you were on irc ;)

> execuse my language and grammar now!
> Now what's next ?
> I can upload the packages, or ask for a sponsor on debian mentors, but 
> tomorrow!
> 

No.. not yet.


Thanks
Mohammed Elzubeir